Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add memory limit & restarts in docker-compose.yml #13343

Merged
merged 2 commits into from
Nov 10, 2023
Merged

chore: add memory limit & restarts in docker-compose.yml #13343

merged 2 commits into from
Nov 10, 2023

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Nov 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolves #12537

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

NA

@fuyufjh fuyufjh requested review from lmatz and wcy-fdu November 9, 2023 10:49
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #13343 (6498fc6) into main (eb4218c) will increase coverage by 0.00%.
Report is 6 commits behind head on main.
The diff coverage is 61.11%.

@@           Coverage Diff           @@
##             main   #13343   +/-   ##
=======================================
  Coverage   67.74%   67.74%           
=======================================
  Files        1525     1524    -1     
  Lines      259436   259425   -11     
=======================================
- Hits       175757   175751    -6     
+ Misses      83679    83674    -5
Flag Coverage Δ
rust 67.74% <61.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/src/catalog/mod.rs 59.91% <100.00%> (ø)
src/common/src/config.rs 84.28% <100.00%> (-0.12%) ⬇️
src/connector/src/lib.rs 58.18% <ø> (-0.75%) ⬇️
src/connector/src/parser/debezium/avro_parser.rs 46.36% <0.00%> (ø)
src/connector/src/schema/schema_registry/mod.rs 0.00% <0.00%> (ø)
...ntend/src/optimizer/plan_node/stream_table_scan.rs 89.60% <0.00%> (ø)
src/stream/src/from_proto/stream_scan.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/create_source.rs 56.32% <40.00%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@fuyufjh fuyufjh added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit b8b812d Nov 10, 2023
28 of 29 checks passed
@fuyufjh fuyufjh deleted the eric/12537_docker_compose_add_resource_limit branch November 10, 2023 02:27
@huangjw806 huangjw806 mentioned this pull request Nov 13, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmatz lmatz lmatz approved these changes

@wcy-fdu wcy-fdu Awaiting requested review from wcy-fdu

Assignees
No one assigned
Labels
type/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add memory constraints to docker-compose.yml
2 participants
@fuyufjh @lmatz